terraform: Add support for GitHub Attestations in TFLint installation#1589
terraform: Add support for GitHub Attestations in TFLint installation#1589wata727 wants to merge 6 commits into
Conversation
Kaniska244
left a comment
There was a problem hiding this comment.
Hi @wata727
Thank you for the contribution. Would you kindly bump the feature version and look into the failing test?
| "features": { | ||
| "terraform": { | ||
| "tflint": "latest" | ||
| "tflint": "0.50.0" |
There was a problem hiding this comment.
Hi @wata727
Instead of pinning a specific version, would you kindly incorporate the gh attestation verify logic in tflint_fallback_test.sh test script?
There was a problem hiding this comment.
Fixed.
By the way, passing the bundle directly allows gh at verify to run even without a GITHUB_TOKEN, but this leaves a rate limiting issue. However, since we're using GitHub's artifact attestations, there seems to be no way to avoid this.
What are your thoughts on this issue? Can we just ignore it since it's unlikely to happen very often?
b6e506a to
a4e7fa6
Compare
|
@Kaniska244 Would appreciate if this update could be prioritized. It appears the endpoint cosign was using has been removed and our builds are now failing without this update. |
Fixes #1563