Skip to content

#2014: Fix CSS warning in the gui#2015

Merged
hohwille merged 2 commits into
devonfw:mainfrom
laim2003:fix/#2014-Wrong-font-style-CSS-configuration-in-center.css
Jun 15, 2026
Merged

#2014: Fix CSS warning in the gui#2015
hohwille merged 2 commits into
devonfw:mainfrom
laim2003:fix/#2014-Wrong-font-style-CSS-configuration-in-center.css

Conversation

@laim2003

@laim2003 laim2003 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

This PR fixes #2014

Implemented changes:

  • fixed center.css using wrong attribute (fx-font-style instead of fx-font-family)

Testing instructions

  1. Run AppLauncher class
  2. No Warning WARNUNG: CSS Error parsing jar:file:/C:/Users/lfaber/projects/IDEasy/conf/mvn/repository/com/devonfw/tools/IDEasy/ide-gui/2026.05.001/ide-gui-2026.05.001.jar!/com/devonfw/ide/gui/style/center.css: Expected '<font-style>' while parsing '-fx-font-style' at [4,18] should be displayed.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Jun 10, 2026
@laim2003 laim2003 self-assigned this Jun 10, 2026
@laim2003 laim2003 added GUI Graphical User Interface of IDEasy (aka dashboard) build with JavaFx internal Nothing to be added to CHANGELOG, only internal story labels Jun 10, 2026
@laim2003 laim2003 moved this from 🆕 New to Team Review in IDEasy board Jun 10, 2026
@laim2003 laim2003 added this to the release:2026.06.001 milestone Jun 10, 2026
@laim2003 laim2003 marked this pull request as ready for review June 10, 2026 10:39
@laim2003 laim2003 requested a review from hohwille June 10, 2026 10:40
@coveralls

coveralls commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 27561444063

Coverage increased (+0.02%) to 71.161%

Details

  • Coverage increased (+0.02%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 1 coverage regression across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/version/VersionSegment.java 1 90.55%

Coverage Stats

Coverage Status
Relevant Lines: 15873
Covered Lines: 11786
Line Coverage: 74.25%
Relevant Branches: 7072
Covered Branches: 4542
Branch Coverage: 64.23%
Branches in Coverage %: Yes
Coverage Strength: 3.15 hits per line

💛 - Coveralls

@laim2003 laim2003 moved this from Team Review to 👀 In review in IDEasy board Jun 12, 2026

@hohwille hohwille left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laim2003 thanks for the PR. Small fixes improving things are always good and easy to review. Ready for merge.

@hohwille hohwille merged commit c23107c into devonfw:main Jun 15, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in IDEasy board Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GUI Graphical User Interface of IDEasy (aka dashboard) build with JavaFx internal Nothing to be added to CHANGELOG, only internal story

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Wrong font-style CSS configuration in center.css

3 participants