fixed pgAdmin macOS dmg installation#2018
Open
shodiBoy1 wants to merge 4 commits into
Open
Conversation
Collaborator
Coverage Report for CI Build 27450388724Coverage decreased (-0.2%) to 70.811%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions121 previously-covered lines in 4 files lost coverage.
Coverage Stats
💛 - Coveralls |
hohwille
reviewed
Jun 15, 2026
hohwille
left a comment
Member
There was a problem hiding this comment.
@shodiBoy1 thanks for analysing and fixing this bug.
The code looks quite redundant to already existing code (e.g. to "extract dmg", the installation routine or to prompt when running privileged operations). I got the impression that we need to understand the root cause properly and fix the bug trying to avoid the copy&paste. I hope we will soon meet in a daily or otherwise to clarify this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #798 and #878
Implemented changes:
.dmg, findpgAdmin 4.app, copy it to/Applicationswithsudo /usr/bin/ditto, then detach the DMG.PgAdmin#getInstallationPath(...)so an existing PATH-based installation is not ignored.pgAdmin4on macOS,pgadmin4on Linux/Windows.sudocommand before entering a password..appdetection.Testing instructions
Check out the PR:
Run on a Mac:
Go to com.devonfw.tools.ide.cli.Ideasy and select Modify Run Configuration.
Use this run configuration:
Main class: com.devonfw.tools.ide.cli.Ideasy
Module: ide-cli
JRE: Java 25
Program arguments:
--debugand8.14are only used to make the manual test easier to verify and reproducible. The normal user command isinstall pgadmin.Working directory: any IDEasy test project folder, e.g. ~/projects/text-fix
Environment variables: IDE_ROOT=~/projects
VM options: -Dfile.encoding=UTF-8
Click Run.
Run the focused automated tests:
mvn -pl cli -Dtest=PgAdminTest testChecklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal