Cleanup and api doc part 1#117
Merged
marcelluethi merged 4 commits intoJun 22, 2026
Merged
Conversation
AxisRemovers and other related type level witnesses used the Aux Pattern, introducing 2 auxiliary type variables in the signature. We introduce instead an explicit type member, which we can directly refer to in the signature, eliminating the additional type parameters.
benikm91
reviewed
Jun 22, 2026
| type NewShape = O | ||
|
|
||
| // Replace single axis with multiple axes | ||
| /** Replace Axis in given Tuple with the Axis in the AxisReplacements tuple */ |
Collaborator
There was a problem hiding this comment.
/** Replace Axis in given Tuple with the Axes in the AxisReplacements tuple */
benikm91
reviewed
Jun 22, 2026
| type RemainingAxes <: Tuple | ||
|
|
||
| object AxesRemover: | ||
| type Aux[T <: Tuple, Axes <: Tuple, R <: Tuple] = AxesRemover[T, Axes] { type RemainingAxes = R } |
benikm91
approved these changes
Jun 22, 2026
benikm91
left a comment
benikm91
left a comment
Collaborator
There was a problem hiding this comment.
Its to much detailed changes and I am not an expert on type level. I approve as it is probably an improvement and the tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first part of an attempt to add api-documentation and clean up the tensor operations.
The most important technical change is that the Aux Pattern was replaced by a more direct approach, where the evidence object has an explicit type member, thereby avoiding auxiliary type parameters (see sum or outerProduct)
Once approved, documentation and cleanup will go on with the remaining tensor operations.