docs: update docs for --sidebar, --app-name, --disable-commands flags, OAuth meta keys rename, and hooks model_id gap#2922
Closed
aheritier wants to merge 1 commit into
Closed
docs: update docs for --sidebar, --app-name, --disable-commands flags, OAuth meta keys rename, and hooks model_id gap#2922aheritier wants to merge 1 commit into
aheritier wants to merge 1 commit into
Conversation
…x hooks model_id gap - docs/features/cli/index.md: add --sidebar, --app-name, --disable-commands flags to the docker agent run flags table (PR #2917, #2914, #2913) - docs/features/remote-mcp/index.md: rename OAuth elicitation Meta keys from cagent/ to docker-agent/ prefix (PR #2915) - docs/configuration/hooks/index.md: add model_id field to before_llm_call and after_llm_call per-event payload table and notes (PR #2911)
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The documentation updates look accurate and complete:
- , , flags: All three entries are correctly described, with accurate default values and behavior descriptions. The note that
--sidebar=falsedisables both Ctrl+B and mouse toggle is consistent with the permanent-hide semantics. - OAuth meta key rename: All 4 keys (
cagent/→docker-agent/) were updated consistently across both the table and all prose references in the unmanaged OAuth section. model_idin hook payload tables: Added to bothbefore_llm_callandafter_llm_callwith a correct clarifying note about theprovider/modelcanonical form.
No bugs or inaccuracies found in the changed lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Catches up
/docswith user-facing changes merged in the last 36 hours.Changes
docs/features/cli/index.md— 3 new flags documentedAdded to the
docker agent runflags table (alongside--leanwhich they complement):--sidebartrue;--sidebar=falsehides it permanently, disabling Ctrl+B and mouse toggle)--app-name <name>/exitnotifications--disable-commands <list>Refs: #2917, #2914, #2913
docs/features/remote-mcp/index.md— OAuth elicitation meta key prefix correctedThe unmanaged OAuth section referenced the old
cagent/key prefix. Updated all four keys to the renameddocker-agent/prefix per #2915:cagent/type→docker-agent/typecagent/server_url→docker-agent/server_urlcagent/authorize_url→docker-agent/authorize_urlcagent/state→docker-agent/stateRefs: #2915
docs/configuration/hooks/index.md—model_idadded to hook payload tablesThe per-event extra fields table was missing
model_idfor bothbefore_llm_callandafter_llm_call. Added the field and a note explaining itsprovider/modelcanonical form. This closes the docs gap explicitly flagged in #2911.Refs: #2911
No changes needed
docs/features/tui/index.md— does not enumerate CLI flags; no update needed.docs/features/mcp-mode/index.md— no stale OAuth meta key references found.docs/features/remote-mcp/index.mdOAuth drive-flow section — already written by Extend unmanaged OAuth flow to drive code exchange in-process #2896 itself; only the key-name rename was stale.