Add user override for default stage direction background and text colour#1287
Open
Tim020 wants to merge 3 commits into
Open
Add user override for default stage direction background and text colour#1287Tim020 wants to merge 3 commits into
Tim020 wants to merge 3 commits into
Conversation
Adds two new nullable columns to UserSettings (default_sd_background_colour, default_sd_text_colour) so users can personalise the fallback appearance applied to unstyled stage direction lines. Includes UI in both Vue 3 and Vue 2 clients, an Alembic migration, E2E coverage, and updated user documentation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
documentation
Client V3 Test Results23 tests 23 ✅ 0s ⏱️ Results for commit c77bc2e. ♻️ This comment has been updated with latest results. |
Client Test Results128 tests 128 ✅ 0s ⏱️ Results for commit c77bc2e. ♻️ This comment has been updated with latest results. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds full end-to-end coverage: default preview colour assertion (verifies darkslateblue fallback), WS sync round-trip (preview updates after PATCH), persistence across page reload (GET /api/v1/user/settings), text colour override path, and Reset to Default restoring the fallback. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Python Test Results 1 files 1 suites 2m 5s ⏱️ Results for commit c77bc2e. |
Playwright E2E Results (firefox)217 tests 217 ✅ 2m 7s ⏱️ Results for commit c77bc2e. |
Playwright E2E Results (chromium)217 tests 217 ✅ 2m 15s ⏱️ Results for commit c77bc2e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
default_sd_background_colouranddefault_sd_text_colourcolumns toUserSettingsso users can personalise the fallback appearance of unstyled stage direction linesdarkslatebluefallback is preserved when no override is setalembic checkconfirms model and DB are in sync14-user-settings.spec.tsdocs/pages/user_settings.mdTest plan
pytest— 704 tests passnpm run typecheck+npm run ci-lint— cleannpm run typecheck+npm run ci-lint— cleanalembic check— no new upgrade operations detected🤖 Generated with Claude Code