Propagate context through all API calls and add --timeout flag#326
Merged
AndreyVMarkelov merged 1 commit intoJul 4, 2026
Merged
Conversation
Thread context.Context through every Dropbox SDK call so that operations respect cancellation and deadlines. Add a global --timeout flag that sets a context deadline for all network operations (e.g. --timeout 30s). The retry loop now respects context cancellation during backoff sleep, and context errors are never retried. Client interfaces are narrowed to only the *Context methods actually used, improving testability. Also hardens CI workflows with explicit read-only permissions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
context.Contextthrough every Dropbox SDK call so operations respect cancellation and deadlines--timeoutflag that sets a context deadline for all network operations (e.g.--timeout 30s,--timeout 2m)*Contextmethods used, improving testabilityTest plan
gofmt— no issuesgo vet— cleango test ./...— all passls /,account,du,search,put,get,rm,revs— all work--timeout 30s ls /— succeeds normally--timeout 1ms ls /— fails withcontext deadline exceeded--timeout -1s ls /— rejected with validation error