Update configuration handling in gateway tests#3995
Merged
Conversation
Previously, test cases never populated `GatewayModel.configuration` or `GatewayComputeModel.configuration`. These fields can only be missing for pre-0.18.2 gateways, so the tests weren't effectively testing the code against relevant gateways. - Populate `GatewayModel.configuration` and `GatewayComputeModel.configuration` in all test cases. - Parametrize some of the more important test cases to also run them without populating `configuration`, representing legacy gateways. - Fix the `/set_wildcard_domain` API method so that it also modifies the gateway configuration to keep it relevant. The fact that it wasn't doing so was surfaced by the above test updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, test cases never populated
GatewayModel.configurationorGatewayComputeModel.configuration. These fieldscan only be missing for pre-0.18.2 gateways, so
the tests weren't effectively testing the code
against relevant gateways.
GatewayModel.configurationandGatewayComputeModel.configurationin all testcases.
cases to also run them without populating
configuration, representing legacy gateways./set_wildcard_domainAPI method sothat it also modifies the gateway configuration
to keep it relevant. The fact that it wasn't
doing so was surfaced by the above test updates.
#3959