Skip to content

Fix returntype of setBPM() to avoid crash on ESP32 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andymann wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix returntype of setBPM() to avoid crash on ESP32 #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ArduinoTapTempo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ float ArduinoTapTempo::getBPM()
return 60000.0 / beatLengthMS;
}

float ArduinoTapTempo::setBPM(float bpm)
void ArduinoTapTempo::setBPM(float bpm)
{
beatLengthMS = 60000 / bpm;
}
Expand Down
2 changes: 1 addition & 1 deletion src/ArduinoTapTempo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class ArduinoTapTempo
bool isChainActive(); // returns true if the current tap chain is still accepting new taps to fine tune the tempo
bool isChainActive(unsigned long ms); // returns true if the current tap chain is still accepting new taps to fine tune the tempo
float getBPM(); // returns the number of beats per minute
float setBPM(float bpm); // sets the number of beats per minute
void setBPM(float bpm); // sets the number of beats per minute
float beatProgress(); // returns a float from 0.0 to 1.0 indicating the percent through the current beat
void resetTapChain(); // resets the current chain of taps and sets the start of the bar to the current time
void resetTapChain(unsigned long ms); // resets the current chain of taps and sets the start of the bar to the current time
Expand Down