Add preferred-orientation (March–Dollase) correction for textured powder samples#200
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #200 +/- ##
===========================================
+ Coverage 90.22% 90.26% +0.03%
===========================================
Files 271 274 +3
Lines 23273 23403 +130
Branches 2718 2729 +11
===========================================
+ Hits 20999 21124 +125
+ Misses 1707 1705 -2
- Partials 567 574 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Powder samples whose crystallites pack with a preferred orientation — platy or needle-like grains — no longer have to be modelled as ideal random powders. You can now add a March–Dollase preferred-orientation correction to each phase of a constant-wavelength Bragg neutron experiment: set the March coefficient and a crystallographic direction, optionally a random-fraction term, then refine them alongside the scale to improve the fit. The setting is saved to and restored from your project CIF and appears in the IUCr-aligned report. Corrections run on the CrysPy engine, and a new cross-engine verification example built on the LBCO dataset demonstrates that the refined result reproduces the equivalent FullProf March–Dollase correction.