Reverted ULONG to be 4 bytes long, fixing missaligment issue in the current port#534
Open
cpdpls wants to merge 2 commits into
Open
Reverted ULONG to be 4 bytes long, fixing missaligment issue in the current port#534cpdpls wants to merge 2 commits into
cpdpls wants to merge 2 commits into
Conversation
Contributor
|
@akifejaz Please review. |
Contributor
Sure, I'll review shortly. Hi @cpdpls, there is PR which enables regression for risc-v ports. It has bunch of tests that runs on both RV32 and RV64. It would be nice if you can try running those. here is how you can run tests.. you would need to merge the upstream/dev branch into yours before running tests. |
Author
|
Hi @akifejaz That was literally the question I was about to ask, so your comment comes in super handy ! I'll surely run the test. Thank you for your input ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix #520. After the recent internal meeting, here is the solution we came up with. The riscv64 port now follows the same type size as other 64-bit architectures in tx_port.h. This also fixes some misalignment issues reported in #520.
This also makes other ThreadX components such as NetX working again (ULONG was assumed to be 4 bytes and not 8 bytes as the current official port).
PR checklist