Fixes #2085: Only warn once per workspace#2094
Conversation
|
@thahnen This change would require bumping at least for the Could you please update the PR with the plugin and feature versions bumped at least by Thanks for the contribution! |
|
Hey @vrubezhny, I bumped up the versions! |
|
@vrubezhny, one question regarding the process: Who will be reviewing this and then merging it? Is it done by some specific persons that I have to ping, or is it something else? |
This could be me or @akurtakov as well as any other committer on the project. |
There was a problem hiding this comment.
Pull request overview
This PR addresses #2085 by persisting the “missing/undetermined Node.js” warning state in workspace preferences so users aren’t warned again after restarting Eclipse in the same workspace.
Changes:
- Replace the in-memory “already warned” flag with an
InstanceScope(workspace) preference flag. - Always route missing-node warnings through the preference-backed guard.
- Bump plugin/feature versions to
1.0.9/1.2.6.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| org.eclipse.wildwebdeveloper.embedder.node/src/org/eclipse/wildwebdeveloper/embedder/node/NodeJSManager.java | Persist “already warned” state in workspace prefs and gate warning dialogs accordingly |
| org.eclipse.wildwebdeveloper.embedder.node/pom.xml | Plugin version bump to 1.0.9-SNAPSHOT |
| org.eclipse.wildwebdeveloper.embedder.node/META-INF/MANIFEST.MF | Bundle version bump to 1.0.9.qualifier |
| org.eclipse.wildwebdeveloper.embedder.node.feature/pom.xml | Feature version bump to 1.2.6-SNAPSHOT |
| org.eclipse.wildwebdeveloper.embedder.node.feature/feature.xml | Feature version bump to 1.2.6.qualifier |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@akurtakov would you be able to merge this branch? It would be great to have it in this June's release of the IDE at best! I have no rights to merge it myself. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
I plan to test it multiple times and there is always smth more urgent that takes over. Will try to find time for it today. |
vrubezhny
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
f1d7fe6
into
eclipse-wildwebdeveloper:master
No description provided.