Skip to content

Fixes #2085: Only warn once per workspace#2094

Merged
vrubezhny merged 2 commits into
eclipse-wildwebdeveloper:masterfrom
thahnen:master
May 29, 2026
Merged

Fixes #2085: Only warn once per workspace#2094
vrubezhny merged 2 commits into
eclipse-wildwebdeveloper:masterfrom
thahnen:master

Conversation

@thahnen
Copy link
Copy Markdown
Contributor

@thahnen thahnen commented Apr 21, 2026

No description provided.

@vrubezhny
Copy link
Copy Markdown
Contributor

@thahnen This change would require bumping at least for the org.eclipse.wildwebdeveloper.embedder.node plugin and org.eclipse.wildwebdeveloper.embedder.node.feature feature versions.

Could you please update the PR with the plugin and feature versions bumped at least by +0.0.1?

Thanks for the contribution!

@thahnen
Copy link
Copy Markdown
Contributor Author

thahnen commented Apr 22, 2026

Hey @vrubezhny, I bumped up the versions!

@thahnen
Copy link
Copy Markdown
Contributor Author

thahnen commented Apr 23, 2026

@vrubezhny, one question regarding the process: Who will be reviewing this and then merging it? Is it done by some specific persons that I have to ping, or is it something else?

@vrubezhny
Copy link
Copy Markdown
Contributor

@vrubezhny, one question regarding the process: Who will be reviewing this and then merging it? Is it done by some specific persons that I have to ping, or is it something else?

This could be me or @akurtakov as well as any other committer on the project.
There's no need to ping anyone unless you're in a hurry. But if you are, feel free to ask for review.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses #2085 by persisting the “missing/undetermined Node.js” warning state in workspace preferences so users aren’t warned again after restarting Eclipse in the same workspace.

Changes:

  • Replace the in-memory “already warned” flag with an InstanceScope (workspace) preference flag.
  • Always route missing-node warnings through the preference-backed guard.
  • Bump plugin/feature versions to 1.0.9 / 1.2.6.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
org.eclipse.wildwebdeveloper.embedder.node/src/org/eclipse/wildwebdeveloper/embedder/node/NodeJSManager.java Persist “already warned” state in workspace prefs and gate warning dialogs accordingly
org.eclipse.wildwebdeveloper.embedder.node/pom.xml Plugin version bump to 1.0.9-SNAPSHOT
org.eclipse.wildwebdeveloper.embedder.node/META-INF/MANIFEST.MF Bundle version bump to 1.0.9.qualifier
org.eclipse.wildwebdeveloper.embedder.node.feature/pom.xml Feature version bump to 1.2.6-SNAPSHOT
org.eclipse.wildwebdeveloper.embedder.node.feature/feature.xml Feature version bump to 1.2.6.qualifier

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@thahnen
Copy link
Copy Markdown
Contributor Author

thahnen commented May 29, 2026

@akurtakov would you be able to merge this branch? It would be great to have it in this June's release of the IDE at best! I have no rights to merge it myself.

thahnen and others added 2 commits May 29, 2026 09:51
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@akurtakov
Copy link
Copy Markdown
Contributor

I plan to test it multiple times and there is always smth more urgent that takes over. Will try to find time for it today.

Copy link
Copy Markdown
Contributor

@vrubezhny vrubezhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@vrubezhny vrubezhny merged commit f1d7fe6 into eclipse-wildwebdeveloper:master May 29, 2026
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants