fix: pass same secrets in runtime_installation_{default,custom}#320
Open
wdconinc wants to merge 2 commits into
Open
fix: pass same secrets in runtime_installation_{default,custom}#320wdconinc wants to merge 2 commits into
wdconinc wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a build inconsistency in containers/eic/Dockerfile by ensuring the runtime installation stage for the custom environment receives the same registry credentials/secrets needed to install from a non-public buildcache, matching the behavior already used elsewhere in the build.
Changes:
- Pass CI/GitHub registry credential secrets into
runtime_installation_customsospack install --use-buildcache onlycan access private/new buildcaches. - Align secret-mount behavior between default and custom runtime installation paths to avoid requiring newly-created buildcaches to be made public.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
wdconinc
moved this to Needs Review
in ePIC Review Board (auto-populated; changes will be discarded)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR fixes an inconsistency that appears when pushing to a new buildcache that is not public yet. In runtime_installation_default we pass secrets to allow buildcache-only installation, but in runtime_installation_custom we don't pass those secrets and require the buildcache to be publicly readable. By default, new buildcaches are not publicly readable.
Note: I'm working around this issue in #318 by setting the buildcache (now that it has been created) to public, in line with past practice. This bug only affects new buildcaches.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply