Skip to content

feat!: add meta.languages to CSS rules#447

Open
Pixel998 wants to merge 4 commits into
mainfrom
feat/add-meta-languages-to-rules
Open

feat!: add meta.languages to CSS rules#447
Pixel998 wants to merge 4 commits into
mainfrom
feat/add-meta-languages-to-rules

Conversation

@Pixel998
Copy link
Copy Markdown
Contributor

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

This PR adds meta.languages to rules, following the decision made during the TSC meeting on 16-Apr-2026.

What changes did you make? (Give an overview)

Added meta.languages to rule definitions and meta.docs.dialects to their docs metadata.

Related Issues

eslint/eslint#20716 (comment)

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage May 10, 2026
@lumirlumir lumirlumir moved this from Needs Triage to Evaluating in Triage May 11, 2026
Copy link
Copy Markdown
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same note applies from eslint/json#238 (review).

This addition could result in a breaking change for end-users, so I think it might need some further investigation.

@Pixel998 Pixel998 marked this pull request as draft May 18, 2026 07:32
@Pixel998 Pixel998 changed the title feat: add meta.languages to CSS rules feat!: add meta.languages to CSS rules May 21, 2026
@Pixel998 Pixel998 marked this pull request as ready for review May 21, 2026 10:54
@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label May 30, 2026
@lumirlumir lumirlumir moved this from Evaluating to Implementing in Triage May 30, 2026
Copy link
Copy Markdown
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Would like @eslint/eslint-tsc to verify before merging since it's a breaking change.

@lumirlumir lumirlumir moved this from Implementing to Second Review Needed in Triage May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion breaking feature

Projects

Status: Second Review Needed

Development

Successfully merging this pull request may close these issues.

2 participants