Skip to content

Add non-canvas element management with controller and service integration#574

Open
stijnpotters1 wants to merge 6 commits into
masterfrom
feat/add-non-canvas-elements
Open

Add non-canvas element management with controller and service integration#574
stijnpotters1 wants to merge 6 commits into
masterfrom
feat/add-non-canvas-elements

Conversation

@stijnpotters1

@stijnpotters1 stijnpotters1 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor
image image image image image

@stijnpotters1 stijnpotters1 self-assigned this Jun 24, 2026
@stijnpotters1 stijnpotters1 requested a review from Matthbo June 24, 2026 14:51
@stijnpotters1 stijnpotters1 linked an issue Jun 24, 2026 that may be closed by this pull request
@stijnpotters1 stijnpotters1 requested a review from philipsens June 24, 2026 14:53
@philipsens

philipsens commented Jun 25, 2026

Copy link
Copy Markdown
Member

Looks good!

There is a difference between the pen-pot tho. In the design, there can be two rows in each component. A type and a name (or ref in the case of an include). The type should be small and bold while the name would be larger. Is there is no name, the type should be the same styling as the name would've been.

Also, I think elements should just be called components.

image

Also, I think each component should be clickable to configure it, even if it has a button to go to the studio. That makes it easy to rename an adapter for example or to delete it.

@stijnpotters1

Copy link
Copy Markdown
Contributor Author
image

Improved!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe sub components defined here should be in their own files

Comment thread src/main/frontend/app/routes/configurations/configuration-overview.tsx Outdated
Comment thread src/main/frontend/app/services/non-canvas-component-service.ts Outdated
Comment thread src/main/frontend/app/routes/configurations/non-canvas-component-context.tsx Outdated
@stijnpotters1 stijnpotters1 force-pushed the feat/add-non-canvas-elements branch from bfb10e5 to fe2d1bd Compare July 1, 2026 09:28
@sonarqubecloud

sonarqubecloud Bot commented Jul 1, 2026

Copy link
Copy Markdown

@stijnpotters1 stijnpotters1 requested a review from Matthbo July 1, 2026 12:03
@philipsens

Copy link
Copy Markdown
Member

It might be interesting to explore the possibility to give this a more flat and calm design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a configure non-canvas elements screen

3 participants