maintenance: prepare sf8.0 migration#25
Merged
Merged
Conversation
11daedb to
eba52fc
Compare
There was a problem hiding this comment.
Pull request overview
This PR prepares the bundle for a Symfony 8 migration by switching DI service configuration from XML to PHP and adjusting request signature extraction away from Request::get().
Changes:
- Replaced
security.xml/request_obfuscator.xmlwith PHP service configurators (security.php,request_obfuscator.php) and updated the bundle extension to load them viaPhpFileLoader. - Updated
RequestSignatureListenerto fetch the signature fromquery/attributesinstead ofRequest::get(). - Updated
phpstan-baseline.neonentries related toRequestSignatureFactory.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Security/Firewall/RequestSignatureListener.php | Updates signature lookup logic for Symfony 8 compatibility. |
| DependencyInjection/RezzzaSecurityExtension.php | Switches DI loader from XML to PHP service config files. |
| Resources/config/services/security.php | New PHP-based service definitions replacing security.xml. |
| Resources/config/services/request_obfuscator.php | New PHP-based service definitions replacing request_obfuscator.xml. |
| phpstan-baseline.neon | Adjusts ignored PHPStan errors to match current findings/paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7f47b9c to
e9c0c65
Compare
e9c0c65 to
d7cbe57
Compare
d7cbe57 to
793c20b
Compare
Azoog
approved these changes
Jun 17, 2026
Kevin-koko
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/fulll/crm.api/issues/12020