Skip to content

maintenance: prepare sf8.0 migration#25

Merged
nio-dtp merged 1 commit into
masterfrom
maintenance/prepare-sf8.0-migration
Jun 18, 2026
Merged

maintenance: prepare sf8.0 migration#25
nio-dtp merged 1 commit into
masterfrom
maintenance/prepare-sf8.0-migration

Conversation

@nio-dtp

@nio-dtp nio-dtp commented Jun 16, 2026

Copy link
Copy Markdown

@nio-dtp nio-dtp force-pushed the maintenance/prepare-sf8.0-migration branch 4 times, most recently from 11daedb to eba52fc Compare June 16, 2026 12:07
@nio-dtp nio-dtp requested a review from Copilot June 16, 2026 12:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares the bundle for a Symfony 8 migration by switching DI service configuration from XML to PHP and adjusting request signature extraction away from Request::get().

Changes:

  • Replaced security.xml / request_obfuscator.xml with PHP service configurators (security.php, request_obfuscator.php) and updated the bundle extension to load them via PhpFileLoader.
  • Updated RequestSignatureListener to fetch the signature from query / attributes instead of Request::get().
  • Updated phpstan-baseline.neon entries related to RequestSignatureFactory.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Security/Firewall/RequestSignatureListener.php Updates signature lookup logic for Symfony 8 compatibility.
DependencyInjection/RezzzaSecurityExtension.php Switches DI loader from XML to PHP service config files.
Resources/config/services/security.php New PHP-based service definitions replacing security.xml.
Resources/config/services/request_obfuscator.php New PHP-based service definitions replacing request_obfuscator.xml.
phpstan-baseline.neon Adjusts ignored PHPStan errors to match current findings/paths.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Security/Firewall/RequestSignatureListener.php Outdated
@nio-dtp nio-dtp force-pushed the maintenance/prepare-sf8.0-migration branch 4 times, most recently from 7f47b9c to e9c0c65 Compare June 17, 2026 06:02
@nio-dtp nio-dtp marked this pull request as ready for review June 17, 2026 06:04
@nio-dtp nio-dtp requested a review from Azoog June 17, 2026 06:05
@nio-dtp nio-dtp force-pushed the maintenance/prepare-sf8.0-migration branch from e9c0c65 to d7cbe57 Compare June 17, 2026 07:58
@nio-dtp nio-dtp force-pushed the maintenance/prepare-sf8.0-migration branch from d7cbe57 to 793c20b Compare June 17, 2026 08:12
@nio-dtp nio-dtp merged commit 4d7bea0 into master Jun 18, 2026
5 checks passed
@nio-dtp nio-dtp deleted the maintenance/prepare-sf8.0-migration branch June 18, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants