fix(test): enable openai intrinsic e2e tests in nightlies#1341
Open
avinash2692 wants to merge 1 commit into
Open
fix(test): enable openai intrinsic e2e tests in nightlies#1341avinash2692 wants to merge 1 commit into
avinash2692 wants to merge 1 commit into
Conversation
The infrastructure these tests need (a vLLM serving ibm-granite/granite-switch-4.1-3b-preview, exposed via VLLM_SWITCH_TEST_BASE_URL) is now provided by the nightly, which adds a Granite Switch phase after the main suite finishes. Closes generative-computing#931. Assisted-by: Claude Code Signed-off-by: Avinash Balakrishnan <avinash.bala@us.ibm.com>
psschwei
approved these changes
Jun 25, 2026
jakelorocco
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #931
Description
Drops the module-level `pytest.mark.skip` from `test/backends/test_openai_intrinsics.py` that was blocking the file from collecting since PR #881. The infrastructure these tests need (a vLLM serving `ibm-granite/granite-switch-4.1-3b-preview`) is now provided by the nightly.
The remaining markers (`e2e`, `openai`, `vllm`, `require_gpu`, CICD-skipif) keep the file gated for laptops and GitHub Actions; only the nightly satisfies all of them simultaneously, so CI here will continue to skip the file under `CICD=1`.
Testing
Attribution
🤖 Assisted-by: Claude Code