ci(spring-matrix): Replace sed hacks with targeted Gradle builds#5397
Open
runningcode wants to merge 3 commits into
Open
ci(spring-matrix): Replace sed hacks with targeted Gradle builds#5397runningcode wants to merge 3 commits into
runningcode wants to merge 3 commits into
Conversation
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ad8da22 | 365.86 ms | 427.00 ms | 61.14 ms |
| abfcc92 | 337.38 ms | 427.39 ms | 90.00 ms |
| b8bd880 | 314.56 ms | 336.50 ms | 21.94 ms |
| 44472da | 313.96 ms | 365.35 ms | 51.39 ms |
| b03edbb | 352.20 ms | 423.69 ms | 71.49 ms |
| f6cdbf0 | 314.19 ms | 357.59 ms | 43.40 ms |
| f064536 | 329.00 ms | 395.62 ms | 66.62 ms |
| 806307f | 357.85 ms | 424.64 ms | 66.79 ms |
| d15471f | 343.13 ms | 361.47 ms | 18.34 ms |
| 6edfca2 | 316.43 ms | 398.90 ms | 82.46 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ad8da22 | 1.58 MiB | 2.29 MiB | 719.83 KiB |
| abfcc92 | 1.58 MiB | 2.13 MiB | 557.31 KiB |
| b8bd880 | 1.58 MiB | 2.29 MiB | 722.92 KiB |
| 44472da | 0 B | 0 B | 0 B |
| b03edbb | 1.58 MiB | 2.13 MiB | 557.32 KiB |
| f6cdbf0 | 0 B | 0 B | 0 B |
| f064536 | 1.58 MiB | 2.20 MiB | 633.90 KiB |
| 806307f | 1.58 MiB | 2.10 MiB | 533.42 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| 6edfca2 | 1.58 MiB | 2.13 MiB | 559.07 KiB |
romtsn
approved these changes
May 19, 2026
Remove the sed-based Android module exclusion from settings.gradle.kts and build.gradle.kts in the Spring Boot matrix workflows. This is unnecessary because `org.gradle.configureondemand=true` ensures Gradle only configures projects needed for the requested tasks. Replace the broad `./gradlew assemble --parallel` with a single targeted Gradle invocation that builds only the specific artifacts needed (shadowJar/bootJar/war + OTel agent). Remove redundant `--build "true"` from test runner invocations since artifacts are already built. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add testClasses tasks to the single Gradle invocation so test sources are pre-compiled. The subsequent systemTest Gradle calls then only execute tests without needing to compile anything. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Already set in gradle.properties. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
runningcode
force-pushed
the
no/optimize-spring-matrix-ci
branch
from
353e4fd to
3e69be9
Compare
runningcode
requested review from
0xadam-brown,
adinauer and
markushi
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sed-based Android module exclusion fromsettings.gradle.ktsandbuild.gradle.ktsin the three Spring Boot matrix workflows — unnecessary becauseorg.gradle.configureondemand=trueensures Gradle only configures projects needed for the requested tasks./gradlew assemble --parallel(which built the entire non-Android project) with a single targeted Gradle invocation that builds only the specific artifacts needed (shadowJar/bootJar/war+ OTel agent)--build "true"from test runner invocations since artifacts are already pre-built🤖 Generated with Claude Code