feat(deno): redis diagnostics channel based integration for deno#21087
Open
isaacs wants to merge 1 commit into
Open
feat(deno): redis diagnostics channel based integration for deno#21087isaacs wants to merge 1 commit into
isaacs wants to merge 1 commit into
Conversation
isaacs
requested review from
andreiborza and
mydea
and removed request for
a team
Contributor
size-limit report 📦
|
isaacs
added a commit
that referenced
this pull request
May 20, 2026
) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
f176fd8 to
0fc320c
Compare
isaacs
added a commit
that referenced
this pull request
May 20, 2026
isaacs
added a commit
that referenced
this pull request
May 20, 2026
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
1048f32 to
72be1fa
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
isaacs
added a commit
that referenced
this pull request
May 21, 2026
isaacs
added a commit
that referenced
this pull request
May 21, 2026
) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
11525d8 to
a8d3cb7
Compare
isaacs
added a commit
that referenced
this pull request
May 21, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
isaacs
added a commit
that referenced
this pull request
May 21, 2026
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
8226aaf to
5863e6c
Compare
isaacs
added a commit
that referenced
this pull request
May 22, 2026
) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
5863e6c to
cd298fa
Compare
Contributor
|
👋 @mydea, @andreiborza — Please review this PR when you get a chance! |
isaacs
added a commit
that referenced
this pull request
May 25, 2026
) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
cd298fa to
b4e4854
Compare
isaacs
added a commit
that referenced
this pull request
May 26, 2026
) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
b4e4854 to
9217baa
Compare
isaacs
added a commit
that referenced
this pull request
May 26, 2026
) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
e46685b to
1f6c601
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1f6c601. Configure here.
| }, | ||
| ]; | ||
|
|
||
| const utf8Decoder = new TextDecoder('utf-8'); |
There was a problem hiding this comment.
Top-level side effect contradicts sideEffects: false
Medium Severity
const utf8Decoder = new TextDecoder('utf-8') is a top-level constructor call (side effect) in a module reachable from @sentry/core's public entry points (server-exports.ts → index.ts). The @sentry/core package declares "sideEffects": false, so bundlers assume every module is purely declarative and may skip executing top-level code. Every other new TextDecoder() / new TextEncoder() call in @sentry/core is scoped inside a function; this is the only module-scope instance. The decoder should be instantiated inside defaultDbStatementSerializer instead.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 1f6c601. Configure here.
JPeer264
reviewed
May 28, 2026
Member
JPeer264
left a comment
JPeer264
left a comment
There was a problem hiding this comment.
LGTM, just have one m which I want to get sorted before approving
| setupCommandChannel(tracingChannel); | ||
| setupBatchChannel(tracingChannel); | ||
| setupConnectChannel(tracingChannel); | ||
| subscribed = true; |
Member
There was a problem hiding this comment.
l: Could it be that the second or third command fails that keeps subscribed = false? It will be called anyways just once, but I think there could be a potential double instrumentation, no?
| setupConnectChannel(tracingChannel); | ||
| subscribed = true; | ||
| } catch { | ||
| // The factory may rely on `node:diagnostics_channel`, which isn't always |
Member
There was a problem hiding this comment.
l: Should we emit a debug log here?
| [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: ORIGIN, | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'db.redis', | ||
| [ATTR_DB_SYSTEM]: DB_SYSTEM_VALUE_REDIS, | ||
| ...(data.batchSize != null ? { 'db.redis.batch_size': data.batchSize } : {}), |
Member
There was a problem hiding this comment.
m: Before we add db.redis.batch_size we should add it to our semantic conventions. I've also seen that for databases the convention is batch.size, so I wonder if we should rather go for this instead: https://opentelemetry.io/docs/specs/semconv/registry/attributes/db/
JPeer264
reviewed
May 28, 2026
| export { instrumentPostgresJsSql } from './integrations/postgresjs'; | ||
|
|
||
| export { | ||
| REDIS_DC_CHANNEL_BATCH, |
Member
There was a problem hiding this comment.
l: One more thing I've noticed while reviewing quickly #21187
Since more and more names will be exported over time we could align on a common wording somewhere for these channel constants.
Contributor
|
👋 @mydea, @andreiborza — Please review this PR when you get a chance! |
mydea
requested review from
logaretm and
nicohrubec
and removed request for
mydea
Member
I'm personally fine with this. Approved the other PR, waiting for @isaacs decision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns.
Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds
_sentrySpanonto the data in a RedisTracingChannelFactory which is passed to the core utility.