feat(hono): Add warning in Bun for double init#21195
Merged
Merged
Conversation
nicohrubec
approved these changes
May 27, 2026
Member
nicohrubec
left a comment
nicohrubec
left a comment
There was a problem hiding this comment.
nice. should we do this for cloudflare as well?
| expect(warnSpy).toHaveBeenCalledWith(expect.stringContaining('Sentry is already initialized')); | ||
| }); | ||
|
|
||
| it('warns that initialization should only happen through the sentry() middleware', () => { |
Member
There was a problem hiding this comment.
l: should this test and the one before maybe be merged? i.e. just have one "warns if sentry is already initialized" and then check both logs or just check that the spy is being called
mydea
reviewed
May 27, 2026
| export function init(options: HonoBunOptions): Client | undefined { | ||
| const existingClient = getClient(); | ||
| if (existingClient) { | ||
| debug.warn( |
Member
There was a problem hiding this comment.
maybe do a console.warn here (wrapped in consoleSandbox)? 🤔
Member
There was a problem hiding this comment.
also I would probably not return early here but still run init again, second init should take precedence I suppose in such a scenario...? (as much as it can, it will be kind of buggy for sure either way)
Member
Author
|
Applied your suggestions, they all make sense :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference #21176