test: restart on crash#1754
Open
jpnurmi wants to merge 4 commits into
Open
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3a45d1a. Configure here.
jpnurmi
force-pushed
the
jpnurmi/test/restart-on-crash
branch
from
3a45d1a to
8173a0f
Compare
jpnurmi
force-pushed
the
jpnurmi/test/restart-on-crash
branch
from
8173a0f to
355af09
Compare
mujacica
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add "restart-on-crash" example + integration tests with all backends.
The example unblocks signals in the restarted POSIX child before
execv(), preventing it from inheriting the crash handler’s blocked signal mask. The integration test verifies that both the original process and the restarted child report crashes.Why example only
The SDK should not silently rewrite an application’s signal mask as part of normal crash handling. Some applications intentionally block signals, and changing that globally would be surprising outside this restart pattern.
Handling only selected crash signals in the SDK is also fragile: the exact set depends on platform and backend behavior, and it still imposes SDK policy on process state. Keeping this in the restart example makes the requirement explicit at the point where the child process is created.
Close: #1114