Fix incorrect input name for upload-code-coverage action#44496
Closed
joshhale wants to merge 1 commit into
Closed
Conversation
The docs showed `report:` as the input for the coverage file path, but the actual action (actions/upload-code-coverage) defines the input as `file:`. Anyone copy-pasting the documented example would silently lose their file path since composite actions ignore unrecognized inputs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
Contributor
Author
|
Closing in favour of a PR in docs-internal per the Hubber contribution process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
The
actions/upload-code-coverage@v1action defines its input asfile:, but the docs incorrectly showreport:. Anyone copy-pasting the example gets a silently broken workflow since composite actions ignore unrecognizedwith:keys.What's being changed (if available, include any code snippets, screenshots, or gifs):
Two occurrences of
report:changed tofile:in the code coverage setup guide (Step 2 snippet and full workflow example), matching the actual action.yml.Check off the following: