Skip to content

fix: correct triage agent paths#5757

Open
fancydirty wants to merge 3 commits into
google:mainfrom
fancydirty:fix/triage-agent-pythonpath
Open

fix: correct triage agent paths#5757
fancydirty wants to merge 3 commits into
google:mainfrom
fancydirty:fix/triage-agent-pythonpath

Conversation

@fancydirty
Copy link
Copy Markdown

@fancydirty fancydirty commented May 19, 2026

Summary

Fixes import paths for the ADK issue and pull request triaging workflows.

The workflows previously set PYTHONPATH to contributing/samples, but both packages live under contributing/samples/adk_team:

  • contributing/samples/adk_team/adk_pr_triaging_agent
  • contributing/samples/adk_team/adk_triaging_agent

As a result, the PR triage job could fail before it could run:

ModuleNotFoundError: No module named adk_pr_triaging_agent

This PR changes both triage workflows to use PYTHONPATH=contributing/samples/adk_team.

It also fixes the PR triaging agent CONTRIBUTING.md lookup. The previous parents[3] path resolved to contributing/CONTRIBUTING.md, but the file is in the repository root, so the correct path is parents[4] / CONTRIBUTING.md.

testing plan

Verified locally with corrected PYTHONPATH and dummy workflow environment variables in the Python 3.10 uv test environment.

Command summary:

GITHUB_TOKEN=dummy PULL_REQUEST_NUMBER=1 ISSUE_NUMBER=1 ISSUE_TITLE=test ISSUE_BODY=test EVENT_NAME=issues PYTHONPATH=contributing/samples/adk_team UV_PROJECT_ENVIRONMENT=.venv310 uv run --python 3.10 --extra test python -c inline_module_spec_check

Verification output:

adk_pr_triaging_agent: True
adk_pr_triaging_agent.main: True
adk_triaging_agent: True
adk_triaging_agent.main: True

@fancydirty fancydirty marked this pull request as ready for review May 19, 2026 16:31
@adk-bot adk-bot added the tools [Component] This issue is related to tools label May 20, 2026
@adk-bot
Copy link
Copy Markdown
Collaborator

adk-bot commented May 20, 2026

Response from ADK Triaging Agent

Hello @fancydirty, thank you for creating this PR!

This PR is a bug fix. To align fully with our contribution guidelines, could you please:

  • Rename your Tests section to testing plan (or include a dedicated testing plan section).
  • Provide the logs or screenshots demonstrating the successful local verification (as outlined in our requirement: "For bug fixes or features, please provide logs or screenshot after the fix is applied to help reviewers better understand the fix").

This information will help reviewers to review your PR more efficiently. Thanks!

@rohityan rohityan self-assigned this May 20, 2026
@rohityan rohityan added the request clarification [Status] The maintainer need clarification or more information from the author label May 20, 2026
@rohityan
Copy link
Copy Markdown
Collaborator

Hi @fancydirty , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Can you please fix the failing unit tests before we can proceed with the review.

@fancydirty
Copy link
Copy Markdown
Author

Hi @rohityan, thanks for the review. I updated the PR description to include a dedicated testing plan section and local verification output for the corrected PYTHONPATH/module resolution. I also refreshed the branch checks after the old failed run; current PR checks are green on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

request clarification [Status] The maintainer need clarification or more information from the author tools [Component] This issue is related to tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants