fix: avoid ApiServer scope shadowing in web reload#5769
Conversation
|
Response from ADK Triaging Agent Hello @he-yufeng, thank you for creating this PR! This PR looks great and addresses issue #5765! To fully follow our contribution guidelines, could you please:
This will help reviewers understand and approve your changes much faster. Thank you! |
|
Hi @he-yufeng , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Please fix formatting errors by running autoformat.sh |
2b7d6a2 to
918c545
Compare
|
Rebased onto current Local validation:
I also checked the changed non-test Python file for the required |
Summary
ApiServerimports inget_fast_api_appweb=Trueplusreload_agents=TruewhileDevServeris availableFixes #5765
To verify
.\.venv\Scripts\python.exe -m py_compile src\google\adk\cli\fast_api.py tests\unittests\cli\test_fast_api.py.\.venv\Scripts\python.exe -m pytest tests/unittests/cli/test_fast_api.py::test_web_reload_agents_uses_module_api_server_import -q -p no:cacheprovideruv run --extra dev pyink --check src\google\adk\cli\fast_api.py tests\unittests\cli\test_fast_api.pygit diff --checkNotes
uv run --extra test ...currently cannot resolve the locked test environment on Windows becauseyarl==1.24.1has nowin_amd64wheel or source distribution.