Show runtime for interrupted tests#102
Open
JaySon-Huang wants to merge 1 commit into
Open
Conversation
Record elapsed time before thread exit on SIGINT and include it in the INTERRUPTED TESTS summary output.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hi! This is a small improvement to make interrupted tests easier to diagnose.
When a test run is stopped early (for example with Ctrl+C), the
INTERRUPTED TESTSsummary currently only shows the test name, without how long it had been running. That makes it harder to tell whether a test was interrupted near the start or after running for a long time.This change records the elapsed time before the worker thread exits on interruption, and includes it in the summary output.
Before:
After:
Changes
runtime_msinTask.run()whenProcessWasInterruptedis raised (beforethread.exit()).print_tests()to showInterrupted: <ms> msfor interrupted tests when runtime is available.Test plan
python3 -m unittest gtest_parallel_tests -vtest_print_interrupted_tests_shows_runtimeHappy to adjust the output format or naming if you have a preference. Thanks for maintaining this project!