Account for coalesced Trailer headers#167
Open
nicholashusin wants to merge 1 commit into
Open
Conversation
The current code assumes that all Trailer headers will be sent as
separate values, such as:
```
Trailer: A
Trailer: B
```
which translates to `map[string][]string{"Trailer": []string{"A",
"B"}}`. In reality, however, the code in this CL utilizes
`httputil.ReverseProxy`, which coalesce the Trailer headers into one
line:
```
Trailer: A, B
```
which translates to `map[string][]string{"Trailer": []string{"A, B"}}`.
Fix this issue by making sure that coalesced comma-separated Trailer
headers are also handled properly.
ojarjur
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code assumes that all Trailer headers will be sent as separate values, such as:
which translates to
map[string][]string{"Trailer": []string{"A", "B"}}. In reality, however, the code in this CL utilizeshttputil.ReverseProxy, which coalesce the Trailer headers into one line:which translates to
map[string][]string{"Trailer": []string{"A, B"}}.Fix this issue by making sure that coalesced comma-separated Trailer headers are also handled properly.