feat: regenerated google-cloud-capacityplanner#8642
Conversation
|
This has been split from #8641 due to test failures. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the CapacityPlanningService from the @google-cloud/capacityplanner package, leaving only the UsageService. It also updates the UsageService proto definitions to make several fields required (such as cloud_resource_type, reservation_type, and reservation_data_level) and updates the generated samples and client code accordingly. Feedback was provided regarding the package version downgrade to 0.1.0 (which would fail npm publishing since 0.1.3 is already released) and the use of a pre-release version of google-gax in the dependencies.
| "url": "https://github.com/googleapis/google-cloud-node.git", | ||
| "directory": "packages/google-cloud-capacityplanner" | ||
| }, | ||
| "version": "0.1.0", |
There was a problem hiding this comment.
Downgrading the package version from 0.1.3 to 0.1.0 will cause publishing to fail on the npm registry, as 0.1.3 has already been released. Please update the generator configuration or upstream templates to preserve the correct version sequence, as manual edits to this file are not allowed.
References
- Do not manually edit generated client configuration JSON files. Any changes or updates must be made upstream in the generator.
| }, | ||
| "dependencies": { | ||
| "google-gax": "^5.0.0" | ||
| "google-gax": "^5.1.1-rc.1" |
There was a problem hiding this comment.
Using a pre-release version (^5.1.1-rc.1) in the dependencies of a production package is discouraged as it can introduce instability for downstream consumers. Please use a stable version of google-gax (e.g., ^5.1.0) in the generator configuration or upstream templates, as manual edits to this file are not allowed.
References
- Do not manually edit generated client configuration JSON files. Any changes or updates must be made upstream in the generator.
1 participant
No description provided.