test(auth): add test for keeping stale credentials on refresh failure#8644
Open
westarle wants to merge 4 commits into
Open
test(auth): add test for keeping stale credentials on refresh failure#8644westarle wants to merge 4 commits into
westarle wants to merge 4 commits into
Conversation
Add graceful degradation test to verify stale but still valid cached credentials are not cleared if a refresh attempt fails. TAG=agy CONV=4aafb1cc-33ea-453d-968d-7e69305c0b3a
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new test case to verify that old stale credentials are not cleared if a refresh attempt fails during a request. The review feedback suggests increasing the expiration and threshold time windows to prevent potential test flakiness in slow CI environments, using Date.now() for better idiomatic code, and adding an assertion to verify that the expiry_date is also preserved.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add graceful degradation test to verify stale but still valid cached credentials are not cleared if a refresh attempt fails.