Skip to content

feat: split workflows package into workflows and workflows-executions#8654

Draft
jskeet wants to merge 3 commits into
googleapis:mainfrom
jskeet:workflows-split
Draft

feat: split workflows package into workflows and workflows-executions#8654
jskeet wants to merge 3 commits into
googleapis:mainfrom
jskeet:workflows-split

Conversation

@jskeet

@jskeet jskeet commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new package @google-cloud/workflows-executions containing the auto-generated client for the Workflow Executions API, while refactoring the existing @google-cloud/workflows package to focus solely on workflow management. Feedback on the changes advises against manually editing any of the generated configuration files, such as package.json, and recommends that any necessary updates (like correcting the repository URL or removing duplicate keywords) be made upstream in the generator.

"name": "@google-cloud/workflows-executions",
"version": "0.1.0",
"description": "Executions client for Node.js",
"repository": "googleapis/nodejs-executions",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Do not manually edit generated client configuration JSON files. Any changes or updates, such as correcting the repository URL, must be made upstream in the generator.

References
  1. Do not manually edit generated client configuration JSON files. Any changes or updates must be made upstream in the generator.

Comment on lines +23 to +24
"executions",
"executions"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Do not manually edit generated client configuration JSON files. Any changes or updates, such as removing duplicate keywords, must be made upstream in the generator.

References
  1. Do not manually edit generated client configuration JSON files. Any changes or updates must be made upstream in the generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant