ci: initial attempt at verify local changes#8661
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new markdown file SKILL.md documenting the steps to verify local changes for the Google Cloud Node.js Firestore SDK. The feedback suggests clarifying that integration tests in Step 3 should be run from the specific package directory to avoid running tests for all packages or encountering failures.
| ## Step 3: Integration Testing | ||
|
|
||
| Integration tests require `GOOGLE_APPLICATION_CREDENTIALS` to be set. | ||
|
|
||
| ```bash | ||
| npm run system-test | ||
| ``` |
There was a problem hiding this comment.
In Step 3, running npm run system-test from the monorepo root might run system tests for all packages (which is slow and requires credentials for all services) or fail if the script is not defined at the root. It is safer to specify that this command should be run from the package directory, or provide both root and package-specific options as done in Step 2.
For example:
## Step 3: Integration Testing
Integration tests require `GOOGLE_APPLICATION_CREDENTIALS` to be set.
```bash
# Navigate to the firestore package if not already there
cd packages/google-cloud-firestore
npm run system-test1 participant
No description provided.