feat(frontend): simplify results page layout+styling & bump pnpm with deps #1018
Merged
Conversation
07ff0e6 to
7af3e31
Compare
7af3e31 to
ca75a2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactorings to the frontend codebase, focusing on UI consistency, user guidance, dependency updates, and test reliability. The most notable changes include the introduction of a reusable
Noticecomponent to standardize notification UI, enhancements to the bookmarklet feature with contextual help, updates to dependencies and build configuration, and refinements to test expectations and API URLs.UI Refactoring and Consistency:
Noticecomponent and refactored various notification and alert UIs throughout the app (App.tsx,AppPanels.tsx) to use this component for consistency and maintainability. [1] [2] [3] [4]DominantFieldcomponent to render an arrow icon for action buttons when the text is'>', improving visual clarity. [1] [2]Bookmarklet Feature Enhancements:
onClickhandler to theBookmarkletcomponent and displaying contextual guidance in the UI. [1] [2] [3] [4] [5] [6] [7]Dependency and Build Configuration Updates:
package.json(includingpnpm,eslint,prettier, and others) and addedpnpm-workspace.yamlto the Docker build context to ensure correct dependency resolution and workspace configuration. [1] [2] [3] [4].dockerignorefor cleaner Docker images.Test and Mock Improvements:
httpsfor the OpenAPI URL instead ofhttp, aligning with production usage and improving test reliability. [1] [2] [3] [4] [5] [6]Minor UI and Accessibility Adjustments:
layout-rail-readingandaria-label/ariaLiveprops in form and notice components. [1] [2] [3]These changes collectively improve the frontend's maintainability, user experience, and reliability in both development and production environments.