Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-05-24 - IconifyIcon Cache Null Type Constraint
**Learning:** The custom `IconifyIcon` component requires caching negative results as `null` instead of `undefined` to satisfy Next.js build constraints for `ExtendedIconifyIcon | null`.
**Action:** Always use `null` for missing items when caching `iconData` lookups in `IconifyIcon.tsx`.
23 changes: 21 additions & 2 deletions client/src/components/base/IconifyIcon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,37 @@ const iconSets: Record<string, IconifyJSON> = {
"mdi-light": mdiLightIcons,
};

// ⚑ Bolt: Cache icon lookups to prevent O(N) array iteration on every render,
// especially for prefix-less or missing icons.
const iconCache = new Map<string, ReturnType<typeof getIconData>>();

const iconData = (icon: string) => {
if (iconCache.has(icon)) {
return iconCache.get(icon);
}

const [prefix, name] = icon.includes(":") ? icon.split(":") : ["", icon];

if (prefix && iconSets[prefix]) {
const data = getIconData(iconSets[prefix], name);
if (data) return data;
if (data) {
iconCache.set(icon, data);
return data;
}
}

for (const [_, icons] of Object.entries(iconSets)) {
const data = getIconData(icons, name);
if (data) return data;
if (data) {
iconCache.set(icon, data);
return data;
}
}

// ⚑ Bolt: Store missing items as `null` (not undefined)
// to satisfy the `ExtendedIconifyIcon | null` constraint in Next.js build.
iconCache.set(icon, null);
return null;
};

const IconifyIcon = ({
Expand Down