⚡ Bolt: [performance improvement] Cache Iconify lookups#48
Conversation
Co-authored-by: sshahriazz <34005640+sshahriazz@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: The
IconifyIconcomponent was iterating through an array of icon sets to look up icon data on every render. This PR introduces aMapcache to store the resolved icon data (ornullfor missing icons).🎯 Why: The previous approach required O(N) iterations on each render for each icon. Since a page can have many icons, this was a performance bottleneck.
📊 Impact: Reduces lookup complexity from O(N) to O(1) by saving CPU cycles when resolving and reusing already-looked-up icons. Faster rendering on heavy pages.
🔬 Measurement: Verify by navigating through the app and rendering components loaded with multiple
IconifyIconelements. Rendering times for those pages should improve. Build times should continue to remain stable since this operates at runtime.PR created automatically by Jules for task 12079222641153476895 started by @sshahriazz