Quality: Missing URL.revokeObjectURL in FileSaver.js causes memory leak#1165
Open
tomaioo wants to merge 1 commit into
Open
Conversation
The saveAs function in FileSaver.js creates a Blob URL with URL.createObjectURL() but never revokes it with URL.revokeObjectURL(). This causes memory leaks, especially problematic if the function is called frequently to save files. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quality: Missing URL.revokeObjectURL in FileSaver.js causes memory leak
Problem
Severity:
Medium| File:src/js/FileSaver.js:L4The saveAs function in FileSaver.js creates a Blob URL with URL.createObjectURL() but never revokes it with URL.revokeObjectURL(). This causes memory leaks, especially problematic if the function is called frequently to save files.
Solution
Store the URL in a variable and revoke it after the download is triggered, or use a setTimeout to revoke after a short delay:
setTimeout(() => URL.revokeObjectURL(url), 0);Changes
src/js/FileSaver.js(modified)