fix(rack): always detach OTel context token after request#518
Merged
Conversation
was previously called inside , which is only invoked when is true. When tracing is disabled or suppressed, the token attached in was never detached, leaving the OTel context stack in a corrupted state for subsequent requests on the same thread. Move the detach call directly into the block of so it runs unconditionally, matching the lifecycle of . Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
arjun-rajappa
force-pushed
the
rack-context-detach
branch
from
ca7f879 to
86f4ac7
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenTelemetry::Context.detach(@trace_token)was previously calledinside
finalize_trace, which is only invoked when::Instana.tracer.tracing?is true. When tracing is disabled orsuppressed, the token attached in
callwas never detached, leavingthe OTel context stack in a corrupted state for subsequent requests on
the same thread.
Move the detach call directly into the
ensureblock ofcallso itruns unconditionally, matching the lifecycle of
Context.attach.