Skip to content

Potential fix for 1 code quality finding #3744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ann0see wants to merge 3 commits into
base: main
Choose a base branch
from
+16 −16
Open

Potential fix for 1 code quality finding #3744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec08897
Apply suggested fix to src/util.h from Copilot Autofix
ann0see Jun 19, 2026
65adbe1
Also change places where values are used
softins Jun 19, 2026
6a67474
Fix formatting
softins Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/audiomixerboard.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,9 +503,9 @@ void CChannelFader::SetupFaderTag ( const ESkillLevel eSkillLevel )

case SL_PROFESSIONAL:
strStile += QString ( "background-color: rgb(%1, %2, %3); }" )
.arg ( RGBCOL_R_SL_SL_PROFESSIONAL )
.arg ( RGBCOL_G_SL_SL_PROFESSIONAL )
.arg ( RGBCOL_B_SL_SL_PROFESSIONAL );
.arg ( RGBCOL_R_SL_PROFESSIONAL )
.arg ( RGBCOL_G_SL_PROFESSIONAL )
.arg ( RGBCOL_B_SL_PROFESSIONAL );
break;

default:
Expand Down
2 changes: 1 addition & 1 deletion src/clientsettingsdlg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,7 @@ CClientSettingsDlg::CClientSettingsDlg ( CClient* pNCliP, CClientSettings* pNSet

pcbxSkill->addItem ( QIcon ( SLPixmap ), tr ( "Intermediate" ), SL_INTERMEDIATE );

SLPixmap.fill ( QColor::fromRgb ( RGBCOL_R_SL_SL_PROFESSIONAL, RGBCOL_G_SL_SL_PROFESSIONAL, RGBCOL_B_SL_SL_PROFESSIONAL ) );
SLPixmap.fill ( QColor::fromRgb ( RGBCOL_R_SL_PROFESSIONAL, RGBCOL_G_SL_PROFESSIONAL, RGBCOL_B_SL_PROFESSIONAL ) );

pcbxSkill->addItem ( QIcon ( SLPixmap ), tr ( "Expert" ), SL_PROFESSIONAL );

Expand Down
24 changes: 12 additions & 12 deletions src/util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,18 +739,18 @@ enum ESkillLevel
};

// define the GUI RGB colors for each skill level
#define RGBCOL_R_SL_NOT_SET 255
#define RGBCOL_G_SL_NOT_SET 255
#define RGBCOL_B_SL_NOT_SET 255
#define RGBCOL_R_SL_BEGINNER 255
#define RGBCOL_G_SL_BEGINNER 255
#define RGBCOL_B_SL_BEGINNER 200
#define RGBCOL_R_SL_INTERMEDIATE 225
#define RGBCOL_G_SL_INTERMEDIATE 255
#define RGBCOL_B_SL_INTERMEDIATE 225
#define RGBCOL_R_SL_SL_PROFESSIONAL 255
#define RGBCOL_G_SL_SL_PROFESSIONAL 225
#define RGBCOL_B_SL_SL_PROFESSIONAL 225
#define RGBCOL_R_SL_NOT_SET 255
#define RGBCOL_G_SL_NOT_SET 255
#define RGBCOL_B_SL_NOT_SET 255
#define RGBCOL_R_SL_BEGINNER 255
#define RGBCOL_G_SL_BEGINNER 255
#define RGBCOL_B_SL_BEGINNER 200
#define RGBCOL_R_SL_INTERMEDIATE 225
#define RGBCOL_G_SL_INTERMEDIATE 255
#define RGBCOL_B_SL_INTERMEDIATE 225
#define RGBCOL_R_SL_PROFESSIONAL 255
#define RGBCOL_G_SL_PROFESSIONAL 225
#define RGBCOL_B_SL_PROFESSIONAL 225

// Stereo signal level meter ---------------------------------------------------
class CStereoSignalLevelMeter
Expand Down
Loading