[6.2] Fixes code style issues in Github Workflow#47914
Open
laoneo wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes code style issues during the Github workflow. Only issue is that no new workflow is started and the test results do not appear here. this comes from a security issue where github doesn't trigger new workflows when the bot changes something in the code base (according to Claude).
Additionally it updates all images to PHP 8.5.
Remark
In Joomla 7.0 we have to remove the phpcs dependency and code style xml file.
Testing Instructions
Check if my extra code style error is fixed in this pr and a new commit is done by the bot.
Actual result BEFORE applying this Pull Request
No code style fix and a failed workflow.
Expected result AFTER applying this Pull Request
Fix is commited to the pr and the other checks are running through.
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed