build: cross-compile images from $BUILDPLATFORM#242
Open
gecube wants to merge 1 commit into
Open
Conversation
Pin the builder stage to the native build platform (FROM --platform=$BUILDPLATFORM) so multi-arch builds cross-compile via the already-parametrised GOARCH=$TARGETARCH instead of running the Go toolchain under QEMU emulation for the non-native architecture. Same resulting images, significantly faster multi-arch builds in CI. Signed-off-by: Gaál György <gb12335@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin the builder stage of all three Dockerfiles to the native build platform:
The build already sets
GOARCH=${TARGETARCH}(andGOOS=${TARGETOS:-linux}), so with the builder running on$BUILDPLATFORMthe Go toolchain cross-compiles natively for each target arch instead of running under QEMU emulation for the non-native one. Same resulting images, much faster multi-arch builds.Proof
docker buildx build --platform linux/amd64,linux/arm64(builder stage rebuilt from scratch,--no-cache-filter builder) — all three build cleanly for both architectures:No functional change to the images.