chore(windows): Delphi 11/12 source compatibility

[MattGyverLee]

Summary

Lets the existing tree compile under Delphi 11 (VER350) and Delphi 12 (VER360) without breaking Delphi 10.3 (VER330). Lowers contributor friction on #4599 and makes a future build-server bump to a paid Delphi 11/12 license a drop-in if/when that's wanted. CI is unchanged: with KEYMAN_DELPHI_VERSION unset, every build script keeps defaulting to Delphi 10.3 (BDS 20.0) exactly as before.

Split off from #16039 per @mcdurdin's review — that PR bundled the 11/12 compat work with the CE-specific build-chain workarounds. This PR is the compat half; the CE half is a separate PR.

Why this is in scope for the Delphi removal roadmap

Delphi 10.3 Pro is no longer obtainable, and CE 10.3 has been removed from Embarcadero's downloads. Any future build-server bump or new contributor onboarding must go to Delphi 11/12. This PR makes that bump a pure environment change rather than a chase for compile errors in vendored third-party code.

What's in the change

1. Build-script knob (CI-safe)

File	Change
resources/build/win/configure_environment.inc.sh	DELPHI_VERSION reads \${KEYMAN_DELPHI_VERSION:-20.0}
resources/build/win/delphi_environment.inc.sh	Same
resources/builder.inc.sh	builder_describe_platform delphi-tool probe also respects KEYMAN_DELPHI_VERSION. Without this, machines with only Delphi 12 installed had all win,delphi-gated targets silently skipped

Default unchanged. CI doesn't set the var; nothing about the canonical 10.3 flow changes.

2. Delphi 11/12 source compat in Keyman-owned code

Five files under common/windows/delphi/. Every change is additive IFDEF arms for VER350 / VER360; the VER330 (10.3) paths are untouched. Each was hit by a real compile failure on Delphi 12; the patch is the minimum needed to keep the existing code shape on 10.3 while letting it compile on 11/12.

File	Change	Why
tools/devtools/SourceRootPath.pas	Add VER350/VER360 -> '22.0'/'23.0'	DelphiMajorVersion needs to know the new BDS install dirs
web/Keyman.System.HttpServer.Base.pas	Extend the IFNDEF VER330 tripwire to also accept VER340/350/360	Existing comment says "may need to check this with updated versions of Delphi" — this is that check
components/FixedTrackbar.pas	Same tripwire extension	Same pattern
general/CleartypeDrawCharacter.pas	EnumFontFamiliesEx integer-return comparison on VER340/350/360 (was VER340-only)	The Win32 wrapper return type changed in 10.4+; existing guard only covered 10.4
general/JsonUtil.pas	Pass [] options arg to TJSONAncestor.ToChars on VER350/360	Delphi 11+ added a required Options parameter

3. Vendored third-party patches (please look here first)

WARNING: This is the highest-risk piece of the PR. Three files under developer/src/ext/. Each hunk is annotated with a // Keyman local patch comment plus a refresh strategy noting the upstream package and what to re-apply when those projects ship Delphi 12-compatible releases.

File	Change	Why
jedi/jcl/jcl/source/common/JclSynch.pas	Wrap Boolean args to CreateEvent / OpenEvent / CreateWaitableTimer / OpenWaitableTimer / OpenSemaphore / CreateMutex / OpenMutex in explicit BOOL(); switch JclWin32.CreateMutex -> Winapi.Windows.CreateMutex	Delphi 12 tightened implicit Boolean->BOOL conversion at call sites. BOOL() is an ordinal-preserving typecast, equivalent to the implicit conversion 10.3 was doing — no runtime semantic change. The CreateMutex unit-resolution switch matches the file's existing pattern for the other Winapi calls
jedi/jvcl/jvcl/run/JvComponent.pas	On VER350+, unconditionally call DoCreate	Embarcadero removed the OldCreateOrder property in Delphi 11; the modern default is equivalent to OldCreateOrder=True
mbcolor/mxs.inc	Add VER350/VER360 blocks defining DELPHI_5_UP ... DELPHI_10_UP	Without these, HTMLColors.pas silently drops Variants from its uses clause and breaks with "Undeclared identifier: 'null'"

4. .gitignore

Add patterns for per-arch version*.res and meson wraplock files. General build-output cleanup; not tied to either Delphi tier.

Reviewer notes

• The vendored ext patches in section 3 are the only place real behaviour potentially shifts. The intent is no runtime change — every cast is value-preserving, and OldCreateOrder=True is what Delphi 11 already does by default. That's the spot most worth a second pair of eyes.
• Untouched on purpose: the compiler stack (kmcmplib, kmc-*, Keyman Core). Those are already Delphi-free per chore(windows): Deprecate use of Delphi #4599 progress and aren't in this PR's blast radius.

User Testing

User testing not required: build-environment / source-compat change with no runtime behaviour modification. CI will exercise the 10.3 default path.

Relates-to

Relates-to: #4599
Replaces: #16039 (split into this PR + #16044)

[keymanapp-test-bot]

User Test Results

Test specification and instructions

ERROR: user tests have not yet been defined

[keyman-server]

This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR.

[mcdurdin]

All looks okay apart from this one thing; I don't have source of Delphi 12 to confirm but it seems precisely backwards.

[mcdurdin]

This seems wrong according to the documentation for OldCreateOrder.

[MattGyverLee]

Thanks for the docs link — I hadn't checked Athens's own documentation, just found somewhere that mentioned OldCreateOrder was removed and applied a defensive patch. Given the JclSynch outcome, this one falls in the same bucket. Reverted in bb05693f6e. If it does turn out to be a real issue on Delphi 12 later, I'll have an actual error message to work from.

[mcdurdin]

Looking at this more deeply. This seems to be total nonsense!

I even took the time to try building with an unmodified JclSynch.pas to verify this -- it is completely unnecessary.

[MattGyverLee]

Fair — reverted in dcef4c29cf. Thanks for actually building without it to check. I'd applied the cast because I'd read that Delphi 12 tightened Boolean→BOOL conversions and figured JCL would need updating, but I hadn't actually seen the failure. Should have tried building first.

[mcdurdin]

It looks pretty but it's pretty wrong. Some of the simpler patches are okay but the patches to jedi code are just plain wrong.

[mcdurdin]

Any movement on this @MattGyverLee? We're need to close stale pull requests so please let me know where you plan to take this.

[MattGyverLee]

Changes since your review:

• Reverted both vendored ext patches per the inline replies.
• FixedTrackbar.pas and HttpServer.Base.pas still have the VER350/VER360 IFNDEF arms — dropping them makes the tripwire fire and my Delphi 12 CE build stops compiling. Added self-documenting comments in each file noting the arms were added to unblock compilation, not because I checked whether the underlying override / workaround is still needed on 11/12. Followed your 2019 attestation pattern in FixedTrackbar, but mine says "not verified" rather than "tested on."
• Removed .wraplock from .gitignore — I'd added it because it was showing up as untracked while I was working. On reflection it's a Meson subproject artifact, not Delphi.
• Trimmed the "so CI is unaffected" tail on the windows.md paragraph.
• Added a KEYMAN_DELPHI_VERSION paragraph to docs/build/windows.md so Delphi 11/12 users can find the knob without reading the PR body.

The mxs.inc patch stays — I hit E2003 Undeclared identifier: 'null' on Delphi 12 without it, so that one has a specific failure I can point to.

[mcdurdin]

Getting closer - trying to reduce the excess verbiage. We don't need explanations of why a change was made as a source comment. Conversely, we don't want to lose track of the fact that we have not done the required checks to move to newer versions of Delphi, if we move the CI/core team to newer versions in the future.

[mcdurdin]

Suggested change

	Not yet fully verified against Vcl.Grids.pas in VER350 (11) or VER360 (12);
	IFNDEF arms added to unblock compilation, override behaviour retained as-is.
	TODO: Not yet fully verified against Vcl.Grids.pas in VER350 (11) or VER360 (12)

[mcdurdin]

Suggested change

	{$IFNDEF VER340}
	{$MESSAGE WARN 'Not yet checked against Delphi 10.4'}
	{$IFNDEF VER360}
	{$IFNDEF VER350}
	{$IFNDEF VER340}
	{$MESSAGE WARN 'TODO: Trackbar scrolling on bottom cell not yet checked against Delphi 10.4, 11.0 or 12.0'}

[mcdurdin]

Suggested change

	{$IFNDEF VER350}
	{$IFNDEF VER360}

[mcdurdin]

Suggested change

	ERROR! Check if this is still needed with Delphi update
	{$MESSAGE ERROR 'Check if Indy URL UTF-8 handling is still needed with Delphi update'}

[mcdurdin]

Suggested change

	{$IFNDEF VER340}
	{$IFNDEF VER340}
	{$MESSAGE WARN 'TODO: Check if Indy URL UTF-8 handling is still needed with Delphi 10.4/11.0/12.0'}