chore(developer): consolidate api-extractor usage in Developer#16135
chore(developer): consolidate api-extractor usage in Developer#16135mcdurdin wants to merge 2 commits into
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
github-actions
Bot
added
developer/
common/
developer/compilers/
resources/
chore
labels
mcdurdin
force-pushed
the
chore/developer/14838-consolidate-api-extractor
branch
from
1ea69c9 to
407ce71
Compare
mcdurdin
force-pushed
the
chore/developer/14838-consolidate-api-extractor
branch
from
407ce71 to
d866049
Compare
ermshiperete
left a comment
ermshiperete
left a comment
There was a problem hiding this comment.
LGTM, except I think the paths are wrong in most of the modified build.sh files.
|
|
||
| # Notes | ||
|
|
||
| These files are used by `typescript_run_api_extractor()` in typescript.inc.sh. |
There was a problem hiding this comment.
We might want to move this sentence to the top of the file. Also, a sentence what api-extractor does or why we do it might be helpful. I guess we're talking about https://api-extractor.com/ ?
We could also reference .github/workflows/api-verification.yml which maybe does a similar thing for the desktop platforms.
| @@ -0,0 +1,15 @@ | |||
| { | |||
| "$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json", | |||
| "extends": "$keyman_root/common/tools/api-extractor/api-extractor.base.json", | |||
There was a problem hiding this comment.
If we would put the variables we replace in uppercase they would be easier to spot.
There was a problem hiding this comment.
True, but fairly low priority? I will leave that this time because keyman_root vs KEYMAN_ROOT 😁
| builder_run_action configure node_select_version_and_npm_ci | ||
| builder_run_action build do_build | ||
| builder_run_action api api-extractor run --local --verbose | ||
| builder_run_action api typescript_run_api_extractor developer/src/kmc-copy main.d.ts |
There was a problem hiding this comment.
I'd guess this should be
| builder_run_action api typescript_run_api_extractor developer/src/kmc-copy main.d.ts | |
| builder_run_action api typescript_run_api_extractor developer/src/kmc-generate main.d.ts |
(similarly in the other build.sh files...)
Test-bot: skip Build-bot: skip release:developer
2 participants
@sinceFixes: #14838
Test-bot: skip