Skip to content

change(web): clarify merge, split edit token-mapping types 🚂#16165

Open
jahorton wants to merge 1 commit into
epic/autocorrectfrom
change/web/edit-token-mapping-types
Open

change(web): clarify merge, split edit token-mapping types 🚂#16165
jahorton wants to merge 1 commit into
epic/autocorrectfrom
change/web/edit-token-mapping-types

Conversation

@jahorton

Copy link
Copy Markdown
Contributor

Seeks to address this string of post-merge review comments: #16124 (review)

Build-bot: skip build:web
Test-bot: skip

Build-bot: skip build:web
Test-bot: skip
@jahorton jahorton requested a review from mcdurdin June 30, 2026 15:43
@github-project-automation github-project-automation Bot moved this to Todo in Keyman Jun 30, 2026
@github-actions github-actions Bot added web/ web/predictive-text/ change Minor change in functionality, but not new labels Jun 30, 2026
@keymanapp-test-bot

keymanapp-test-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

  • Web
    • KeymanWeb Test Home - build : all tests passed (no artifacts on BuildLevel "build")

@keymanapp-test-bot keymanapp-test-bot Bot changed the title change(web): clarify merge, split edit token-mapping types change(web): clarify merge, split edit token-mapping types 🚂 Jun 30, 2026
@keymanapp-test-bot keymanapp-test-bot Bot added this to the A19S32 milestone Jun 30, 2026
Comment on lines +50 to +57
/**
* The index of the affected token.
*/
index: number,
/**
* The token's most likely represented text.
*/
text: string,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these need to be repeated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change Minor change in functionality, but not new epic-autocorrect web/predictive-text/ web/

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants