fix(web): define IME interfaces in KeyboardInterfaceBase#16170
Open
mcdurdin wants to merge 2 commits into
Open
fix(web): define IME interfaces in KeyboardInterfaceBase#16170mcdurdin wants to merge 2 commits into
KeyboardInterfaceBase#16170mcdurdin wants to merge 2 commits into
Conversation
keymanapp-test-bot
Bot
added
has-user-test
user-test-required
User Test ResultsTest specification and instructions
Results TemplateTest Artifacts
|
mcdurdin
commented
Jul 1, 2026
Member
Author
There was a problem hiding this comment.
Merged the compatibility pages into interface folder, because all the functions were part of the interface object.
Ensure that the IME interface methods are all defined for both browser and webview modes. Deprecate 'Element' methods and replace with 'TextStore' to clarify return type. Add deprecation flags where needed and update documentation accordingly. Fixes: #16144
mcdurdin
force-pushed
the
fix/web/16144-define-interfaces-for-imes-in-base
branch
from
0663ee4 to
0fc869f
Compare
Contributor
|
Hello, @mcdurdin. I don't think this PR has the fixed for "fetching keyboard from server" since I am seeing this when launching the apk. I can revisit to do the testing at another time. 
|
Member
Author
Right, I've just merged in the patch from master so the new build on this branch should work I hope! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the IME interface methods are all defined for both browser and webview modes. Deprecate 'Element' methods and replace with 'TextStore' to clarify return type. Add deprecation flags where needed and update documentation accordingly.
Fixes: #16144
User Testing