refactor(web): rename keymanweb to keyman in UI modules#16174
Open
mcdurdin wants to merge 1 commit into
Open
Conversation
The variable name `keymanweb` used in the UI modules is confusing because `KeymanWeb` also exists and points to something else. Rename to `keyman` which just mirrors `window.keyman`. Also fixup type declaration for toolbar `lastDismissalCallback`, which did not match the assigned type. Fixes: #16168 Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
requested review from
ermshiperete and
jahorton
and removed request for
jahorton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable name
keymanwebused in the UI modules is confusing becauseKeymanWebalso exists and points to something else. Rename tokeymanwhich just mirrorswindow.keyman.Also fixup type declaration for toolbar
lastDismissalCallback, which did not match the assigned type.Fixes: #16168
Test-bot: skip