fix(android): fix setting font#16178
Draft
ermshiperete wants to merge 1 commit into
Draft
Conversation
keymanapp-test-bot
Bot
added
the
user-test-missing
User Test ResultsTest specification and instructions
Results TemplateTest Artifacts |
Member
|
Does this resolve the crash in Sample1 (#16180) or is it a separate issue? |
ermshiperete
force-pushed
the
fix/android/16096_followup
branch
from
eb809e5 to
12cda26
Compare
The previous PR (#16146) introduced a problem with selecting a different font for a keyboard so that we always ended up with not setting the font. This was caused by the font filenames now being a URL (which is necessary because they get processed by the web engine). However, the Android code checks for the existence of the font in order to create the typeface. This only works for local paths. This change checks if a filename is a URL and converts to a local path, thus allowing `File.exists()` to succeed. Follows: #16146 Build-bot: release:android
ermshiperete
force-pushed
the
fix/android/16096_followup
branch
from
12cda26 to
035af3c
Compare
Contributor
Author
Contributor
Author
|
Hmm, I'm not sure that my analysis "we always ended up with not setting the font" is correct. I can see in the debugger that without the changes in this PR |
keymanapp-test-bot
Bot
added
has-user-test
user-test-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous PR introduced a problem with selecting a different font for a keyboard so that we always ended up with not setting the font. This was caused by the font filenames now being a URL (which is necessary because they get processed by the web engine). However, the Android code checks for the existence of the font in order to create the typeface. This only works with local paths. This change checks if a filename is a URL and converts to a local path, thus allowing
File.exists()to succeed.Follows: #16146
Fixes: #16187
Build-bot: release:android
User Testing
TEST_FONT: