features-sql: avoid redundant meta queries for large result limits#530
Merged
Conversation
A query with a large limit is split into limit/chunkSize query sets, each carrying its own meta query. Previously every chunk re-ran the full numberMatched count and, with computeNumberMatched enabled, meta queries kept being issued even after the result was exhausted - producing hundreds of identical counts for a single page. numberMatched is now computed only on the first chunk of each collection (it is invariant across chunks); later chunks reuse that value. Meta queries also stop once the limit is reached or a collection is exhausted, independent of computeNumberMatched. MetaQueryTemplate gains a withNumberMatched flag; the now-obsolete allowSkipMetaQueries flag is removed.
azahnen
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A query with a large limit is split into limit/chunkSize query sets, each carrying its own meta query. Previously every chunk re-ran the full numberMatched count and, with computeNumberMatched enabled, meta queries kept being issued even after the result was exhausted - producing hundreds of identical counts for a single page.
numberMatched is now computed only on the first chunk of each collection (it is invariant across chunks); later chunks reuse that value. Meta queries also stop once the limit is reached or a collection is exhausted, independent of computeNumberMatched.
MetaQueryTemplate gains a withNumberMatched flag; the now-obsolete allowSkipMetaQueries flag is removed.
Closes ldproxy/ldproxy#1643