Accessibility Feature

[armele]

Closes Discord Suggestion

Changes proposed in this pull request

• Introduce a client-side setting allowing a player to display a 'badge' under the item stack count for greater visibility
• Allow this same feature to be indicated through the layout with a new attribute.

AI

I did use AI on this feature - both to understand the current functionality, and to implement (and then review) the changes. I did review every line of changes to ensure I had a solid understanding of the purpose.

Example

Testing

• Yes I tested this before submitting it.
• I also did a multiplayer test.

Review please

[CLAassistant]

All committers have signed the CLA.

[Raycoms]

In this UI specifically, can't we set a black font on the itemicon?

[armele]

From the XSD what I saw was that only has item, nbt, properties, and renderItemDecorations; no color/textcolor... (Didn't see anything in the ItemIcon classes or nearby that would contradict that, either.) We could theoretically add plumbing to allow a color to be specified at design time (maybe at the BOWindow level?) but I feel like that would be even more heavy-handed, while also not allowing the player to decide if they need the higher contrast rendering. The advantage is that it would be per-window rather than literally every ItemIcon... I will of course defer to your wishes!

[Thodor12]

Do not trust the XSD