Skip to content

LCORE-2395: remove read-only mount for llama-stack config#1815

Open
are-ces wants to merge 2 commits into
lightspeed-core:mainfrom
are-ces:lcore-2395-enrichment-readonly-fix
Open

LCORE-2395: remove read-only mount for llama-stack config#1815
are-ces wants to merge 2 commits into
lightspeed-core:mainfrom
are-ces:lcore-2395-enrichment-readonly-fix

Conversation

@are-ces
Copy link
Copy Markdown
Contributor

@are-ces are-ces commented May 29, 2026

Description

Two Makefile fixes for make run:

  1. Remove ro from run.yaml mount — the enrichment script writes the enriched config back to run.yaml at startup, so the volume mount must be writable. The ro flag was causing enrichment to fail with a read-only filesystem error.

  2. Add make run-local target — restores the pre-LCORE-1872 behaviour as a dedicated target: starts only the lightspeed-stack service, assuming llama-stack is already running externally (e.g. via docker compose or a separate process). Useful for local development iteration without rebuilding the container image.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: Claude
  • Generated by: Claude Sonnet 4.6 (1M context)

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  1. Run make run — verify enrichment completes without read-only filesystem errors and llama-stack starts correctly.
  2. With llama-stack already running separately, run make run-local — verify lightspeed-stack starts without attempting to build/start any container.

🤖 Generated with Claude Code

The enrichment script writes the enriched config back to run.yaml,
so the volume mount must be writable.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Walkthrough

The Makefile start-llama-stack-container recipe volume mount for the configuration file is updated to enable write access by removing the read-only flag (:ro), while preserving SELinux relabeling (:z).

Changes

Container config mount write access

Layer / File(s) Summary
Container config mount permission
Makefile
The volume mount for $(LLAMA_STACK_CONFIG) mapped to /opt/app-root/run.yaml changes from read-only (:ro,z) to writable (:z), allowing the container process to modify the mounted configuration file.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • lightspeed-core/lightspeed-stack#1800: Both PRs address the same run.yaml write-enrichment startup issue: main PR changes the start-llama-stack-container mount to allow writing to /opt/app-root/run.yaml, while the retrieved PR avoids that write by moving enriched config output to /tmp/enriched-run.yaml.
  • lightspeed-core/lightspeed-stack#1760: The main PR's Makefile change adjusts the start-llama-stack-container volume mount for $(LLAMA_STACK_CONFIG) (dropping :ro while keeping :z), which directly builds on the container start/mount logic introduced in PR #1760.

Suggested reviewers

  • tisnik
  • radofuchs
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing the read-only mount flag from the llama-stack config, which aligns with the actual modification in the Makefile.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…tration

Restores the pre-LCORE-1872 behaviour as a separate target: run-local
starts only the lightspeed-stack service, assuming llama-stack is already
running externally (e.g. via docker compose or a separate process).

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@are-ces are-ces requested review from anik120 and tisnik and removed request for tisnik June 1, 2026 07:04
Copy link
Copy Markdown
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants