fix: remove appId parameter from token request#1626
Merged
Conversation
The token request no longer requires the appId from tray-loader when requesting an activation token from the outer compositor. This change was made to simplify the token retrieval process, as the appId parameter is not needed by the outer compositor for token generation in this context. Log: Removed unnecessary appId parameter from token request Influence: 1. Test activation token generation and validation 2. Verify token request works without appId parameter 3. Ensure existing functionality remains intact fix: 移除令牌请求中的 appId 参数 当从外部合成器请求激活令牌时,不再需要 tray-loader 传递的 appId。此更 改简化了令牌获取流程,因为在此上下文中,外部合成器生成令牌不需要 appId 参数。 Log: 移除令牌请求中不必要的 appId 参数 Influence: 1. 测试激活令牌的生成和验证功能 2. 验证没有 appId 参数时令牌请求是否正常 3. 确保现有功能不受影响
There was a problem hiding this comment.
Sorry @18202781743, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
deepin pr auto review这段代码的修改看起来是将
建议改进: void XdgActivationTokenV1::xdg_activation_token_v1_commit(Resource *resource)
{
// Store this token as pending and request from the outer compositor
m_manager->setPendingToken(this);
m_manager->requestOuterToken(m_appId); // 恢复原来的参数
}如果确实需要修改这个函数调用,应该:
例如,如果修改是必要的,可以这样改进: void XdgActivationTokenV1::xdg_activation_token_v1_commit(Resource *resource)
{
// Store this token as pending and request from the outer compositor
m_manager->setPendingToken(this);
// 如果没有有效的appId,使用空字符串而不是空对象
if (m_appId.isEmpty()) {
qWarning() << "Attempting to request activation token with empty appId";
m_manager->requestOuterToken("");
} else {
m_manager->requestOuterToken(m_appId);
}
}这样的修改更加安全,并且提供了更好的错误处理和日志记录。 |
BLumia
approved these changes
Jun 9, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The token request no longer requires the appId from tray-loader when
requesting an activation token from the outer compositor. This change
was made to simplify the token retrieval process, as the appId parameter
is not needed by the outer compositor for token generation in this
context.
Log: Removed unnecessary appId parameter from token request
Influence:
fix: 移除令牌请求中的 appId 参数
当从外部合成器请求激活令牌时,不再需要 tray-loader 传递的 appId。此更
改简化了令牌获取流程,因为在此上下文中,外部合成器生成令牌不需要 appId
参数。
Log: 移除令牌请求中不必要的 appId 参数
Influence: