fix: resolve CI failures in TypeDB, WireMock, and Miniflare#138
Draft
whummer wants to merge 5 commits into
Draft
fix: resolve CI failures in TypeDB, WireMock, and Miniflare#138whummer wants to merge 5 commits into
whummer wants to merge 5 commits into
Conversation
- typedb: update DriverOptions call to use new DriverTlsConfig.disabled() API (typedb-driver 3.8+ replaced is_tls_enabled kwarg with DriverTlsConfig object) - wiremock: pin urllib3<2 in Lambda requirements to avoid Python 3.9 incompatibility (urllib3 2.x uses bytes|str union syntax which requires Python 3.10+) - miniflare: install libvirt-dev system package before pip install in CI (localstack-ext now depends on libvirt-python which requires the system library) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- typedb: mark test_connect_to_h2_endpoint_non_typedb as xfail since LocalStack 2026.5.x no longer advertises HTTP/2 via ALPN on the HTTPS port - wiremock: bundle stubs.json locally and update create-stubs.sh to use it as primary source (external library.wiremock.org URL was returning empty body) - miniflare: change CLOUDFLARE_API_BASE_URL from HTTPS to HTTP in CI since LocalStack extension routes are only matched on HTTP in recent versions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
GITHUB_HEAD_REF##*/ strips everything up to the last slash, turning fix/ci-failures into ci-failures which is not a valid branch ref. Use the full branch name instead. Also add --fail to the curl check so the step actually fails when the extension is not loaded. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The git URL approach with a slashed branch name (fix/ci-failures) causes pip inside the LocalStack extensions venv to fail. Since the code is already checked out by actions/checkout, install directly from the local path to avoid any git URL branch-name parsing issues. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When the `h2` Python package is installed, Twisted's Site.acceptableProtocols() advertises h2 first. ALPN then negotiates HTTP/2 for HTTPS connections, but LocalStack's WSGI-based gateway pipeline is incompatible with HTTP/2 frames, causing requests to fall through to the S3 legacy catch-all (NoSuchBucket). Override TwistedGateway.acceptableProtocols() to return only [b"http/1.1"] until HTTP/2 is properly supported upstream in rolo/localstack-core. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeDB
WireMock
Miniflare
Test plan
🤖 Generated with Claude Code