Add fallback logic for interface detection when ifconfig is unavailable!#25
Open
Anushree-Mathur wants to merge 1 commit into
Open
Add fallback logic for interface detection when ifconfig is unavailable!#25Anushree-Mathur wants to merge 1 commit into
Anushree-Mathur wants to merge 1 commit into
Conversation
The test fails with error "Device None
does not exist" because the underlying
utils_misc.get_interface_from_pci_id()
function relies on the deprecated ifconfig
command, which is not installed by
default.
When ifconfig is unavailable, the function returns None, causing the test to
attempt configuring a network interface named "None", which fails.
This patch adds a fallback mechanism that:
1. Detects when get_interface_from_pci_id() returns None
2. Uses the modern 'ip' command to list network interfaces
3. Reads PCI addresses from /sys/class/net/{iface}/device/uevent
4. Matches PCI addresses to find the correct interface name
The fallback only activates when the primary method fails, ensuring no impact
on systems where ifconfig is available.
Signed-off-by: Anushree-Mathur <anushree.mathur@linux.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test fails with error "Device None
does not exist" because the underlying
utils_misc.get_interface_from_pci_id()
function relies on the deprecated ifconfig
command, which is not installed by
default.
When ifconfig is unavailable, the function returns None, causing the test to attempt configuring a network interface named "None", which fails.
This patch adds a fallback mechanism that:
The fallback only activates when the primary method fails, ensuring no impact on systems where ifconfig is available.
Signed-off-by: Anushree-Mathur anushree.mathur@linux.ibm.com